replace unwrap() with expect("unique message") #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unwrap() gives no clues where to look when a bug arises. This change
replaces common tdigest unwrap() calls with expect("message").
This does the same thing as unwrap(), it just provides more context
for users to report with bugs.
Fwiw, I find that explaining an expectation in rust can sometimes
show me that the expectation is unreasonable. I can't come up with
good explanations for some of these, but I gave an effort to at
least provide a first-approximation of what the expectation at work
is. Any refinements to what these expectations are actually trying
to assert would be welcome!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unwrap() gives no clues where to look when a bug arises. This change
replaces common tdigest unwrap() calls with expect("message").
This does the same thing as unwrap(), it just provides more context
for users to report with bugs.
Fwiw, I find that explaining an expectation in rust can sometimes
show me that the expectation is unreasonable. I can't come up with
good explanations for some of these, but I gave an effort to at
least provide a first-approximation of what the expectation at work
is. Any refinements to what these expectations are actually trying
to assert would be welcome!
It would be nice to be able to provide more information for #680
I've only got a couple years of experience with Rust, but I'd strongly
recommend taking a "no unwrap() outside of tests" policy!