Simplify job history retention by replacing binary search and temp table#9561
Open
Simplify job history retention by replacing binary search and temp table#9561
Conversation
|
@Poroma-Banerjee, @dbeck: please review this pull request.
|
svenklemm
force-pushed
the
sven/temp_table
branch
from
3a1b171 to
d6a33d5
Compare
Remove the job_history_bsearch function and the temp table + TRUNCATE + INSERT pattern. The retention function now uses two simple DELETE statements: one to remove rows older than the cutoff and one CTE-based delete for per-job limits. This also removes the ACCESS EXCLUSIVE lock (no longer needed without TRUNCATE) and switches from execution_finish to execution_start so the existing indexes are utilized.
svenklemm
force-pushed
the
sven/temp_table
branch
from
d6a33d5 to
262179f
Compare
antekresic
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the job_history_bsearch function and the temp table + TRUNCATE +
INSERT pattern. The retention function now uses two simple DELETE
statements: one to remove rows older than the cutoff and one CTE-based
delete for per-job limits. This also removes the ACCESS EXCLUSIVE lock
(no longer needed without TRUNCATE) and switches from execution_finish
to execution_start so the existing indexes are utilized.