Skip to content

fix: avoid duplicate pages information #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

fix: avoid duplicate pages information #265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c5aca
fix: avoid duplicate pages information
sellisd Jan 20, 2025
0829305
fix: remove unecessary casting to list
sellisd Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tldr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def get_platform() -> str:


def get_platform_list() -> List[str]:
platforms = ['common'] + list(OS_DIRECTORIES.values())
platforms = ['common'] + list(set(list(OS_DIRECTORIES.values())))
Copy link
Member

@sebastiaanspeck sebastiaanspeck Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = ['common'] + list(set(list(OS_DIRECTORIES.values())))
platforms = ['common'] + list(set(OS_DIRECTORIES.values()))

Have you tried like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried like this?

It doesn't work because we can't concatenate set and list with the plus operator (+), so we need to cast it back to a list. We can however skip the inner conversion:

['common']+list(set(OS_DIRECTORIES.values()))

so we go from dict_values to set to list, and we gain one step 8)

current_platform = get_platform()
platforms.remove(current_platform)
platforms.insert(0, current_platform)
Expand Down
Loading