Added two new filters to the list endpoints CLI #386
Merged
+68
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@mitali401 we don't want usage_type? it's being exposed in the API already no? |
mitali401
force-pushed
the
endpoint-filters
branch
from
5bfc627 to
4130d28
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mitali401
reviewed
Oct 30, 2025
There was a problem hiding this comment.
we don't filter mine = false https://github.com/togethercomputer/together-dedicated-endpoints/blob/main/tapi/endpoints.go#L39 right now
should we remove it from cli?
|
@mitali401 could you do a final review and approve? |
mitali401
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added usage_type and mine filters to list method for endpoint retrieval
This update extends the list method in the endpoints client to support two new optional filters:
usage_type: Allows filtering endpoints by usage category ("on-demand" or "reserved").
mine: Enables filtering endpoints based on ownership (owned by the caller vs. others).