This repository was archived by the owner on Oct 31, 2024. It is now read-only.
feat(p2p/tce): add gossipsub message_id to tce logs#488
Open
feat(p2p/tce): add gossipsub message_id to tce logs#488
Conversation
12f667b to
40b7fc3
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
40b7fc3 to
b1a3714
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
- Coverage 72.21% 72.02% -0.20%
==========================================
Files 219 219
Lines 12829 12867 +38
==========================================
+ Hits 9265 9267 +2
- Misses 3564 3600 +36 ☔ View full report in Codecov by Sentry. |
a473cae to
d501785
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
d501785 to
836c39a
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To better understand the flow of a message on the network, we expose the
MessageIdgenerated during the GossipSub publication ofGOSSIP|ECHO|READYmessage.This
message_idwill then be placed in every related logs as metadata in order to filter on them in dashboard for exploration.PR Checklist: