fix(useInterval): remove window prefix from setInterval and clearInterval for platform independence#345
Merged
kimyouknow merged 5 commits intotoss:mainfrom Mar 18, 2026
Conversation
…rval for platform independence Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kimyouknow
reviewed
Mar 18, 2026
…ithub.com/eunwoo-levi/react-simplikit into fix/fix-useInterval-platform-independence
Contributor
Author
|
@kimyouknow Added a patch changeset! Thanks for the review:) |
There was a problem hiding this comment.
Pull request overview
This PR updates the useInterval hook in packages/core to avoid browser-only window.* timer APIs so it works in non-browser environments (e.g., React Native, SSR).
Changes:
- Replace
window.setInterval/window.clearIntervalwith globalsetInterval/clearIntervalinuseInterval. - Add a patch changeset documenting the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/hooks/useInterval/useInterval.ts | Removes window.* timer usage to make the hook platform-independent. |
| .changeset/silly-pumas-swim.md | Adds release-note entry for the timer API change. |
| 'react-simplikit': patch | ||
| --- | ||
|
|
||
| fix useInterval to use globalThis instead of window for platform independence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Problem
useIntervalusedwindow.setIntervalandwindow.clearInterval, which are browser-only APIs.This breaks in non-browser environments like React Native and SSR.
Solution
Replace
window.setInterval/window.clearIntervalwith the globalsetInterval/clearInterval.Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?