Draft
Conversation
|
@chriskrycho how can I help to get this finished? I started defining the types locally to be able to use this in my own codebase. |
Contributor
Author
|
@mamiller93 a few steps:
That should do it. Feel free to open a PR against this PR with that set of changes! Note that I may be slower to respond, however, as I'm on vacation until Aug. 2. |
|
🙏 |
|
Friendly reminder this is still open... Something blocking? Would love to use TS. |
|
Anyone interested in pushing this over the finish line? |
Contributor
Author
|
I'm going to push it over the finish line either in the next two weeks (if I get Ember's core types published!) or in mid-January if no one beats me to it. It's simple and easy, though, so someone should beat me to it. ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38. Needs a rebase!