[PTECH-34068] Respect shouldAnimateItems in diffing section controllers#138
Open
[PTECH-34068] Respect shouldAnimateItems in diffing section controllers#138
shouldAnimateItems in diffing section controllers#138Conversation
`DiffingListSectionController`, `ManualDiffingListSectionController`, and `FoundationDiffingListSectionController` all override `calculateUpdate(from:to:)` but do not pass `shouldAnimateItems(from:to:)` to the `CollectionViewSectionUpdate` initializer, causing it to always default to `true`. This means subclasses that override `shouldAnimateItems` to return `false` have no effect — updates are always animated. Fix by threading the `shouldAnimateItems` result through to the `shouldAnimate` parameter in all three controllers, matching the behavior of the base `ListSectionController.calculateUpdate`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gmarm
changed the title
shouldAnimateItems in diffing section controllers
2 tasks
caioremedio
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: PTECH-34068
Summary
Fixes section controller base classes to respect
shouldAnimateItems(from:to:)overrides.DiffingListSectionController,ManualDiffingListSectionController, andFoundationDiffingListSectionControllerall overridecalculateUpdate(from:to:)but never passshouldAnimateItems(from:to:)to theCollectionViewSectionUpdateinitializer, causing it to always default totrue.This means subclasses that override
shouldAnimateItemsto returnfalsehave no effect — updates are always animatedFix by threading the
shouldAnimateItemsresult through to theshouldAnimateparameter in all three controllers, matching the behavior of the baseListSectionController.calculateUpdate.