Add --no-unicode flag to disable combining marks in output #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new command-line flag `--no-unicode` that allows users to disable Unicode combining marks (strikethrough and underline characters) in the diff output while preserving ANSI color highlighting. This addresses the issue where the dual formatting (colors + unicode marks) creates difficulties when converting output to HTML and LaTeX formats. The implementation: - Adds `--no-unicode` flag to the argument parser in __main__.py - Passes the `enable_unicode` parameter to the Printer constructor - Sets the `CombiningMarkWriter.enabled` property based on user preference When `--no-unicode` is specified, only ANSI colors are used to highlight additions (green) and deletions (red), making the output easier to process downstream while maintaining visual differentiation. Fixes #35 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Author
|
cc: @smoelius |
Collaborator
|
This PR doesn't seem to disable combining markers in unicode output, it disables all output, if I am reading the code changes correctly. I need to test it a bit more to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new command-line flag
--no-unicodethat allows users to disable Unicode combining marks (strikethrough and underline characters) in the diff output while preserving ANSI color highlighting. This addresses the issue where the dual formatting (colors + unicode marks) creates difficulties when converting output to HTML and LaTeX formats.The implementation:
--no-unicodeflag to the argument parser in main.pyenable_unicodeparameter to the Printer constructorCombiningMarkWriter.enabledproperty based on user preferenceWhen
--no-unicodeis specified, only ANSI colors are used to highlight additions (green) and deletions (red), making the output easier to process downstream while maintaining visual differentiation.Fixes #35
🤖 Generated with Claude Code