Move tasks db to filesystem #596
Conversation
| from lab.task import Task as TaskService | ||
|
|
||
|
|
||
| class TasksService: |
There was a problem hiding this comment.
Is there a reason to make these async?
There was a problem hiding this comment.
This is just to preserve the DB pattern where those functions were async so I dont break anything in those terms. I understand we wanted to remove async awaits so I could get rid of the async part by looking at the usage in different places if you prefer
There was a problem hiding this comment.
I think it is better if we don't make things async if they don't need it. It might beneift us down the road too (in the past we had to have multiple versions of somethings).
| """Service for managing tasks using filesystem storage""" | ||
|
|
||
| def __init__(self): | ||
| self.task_service = TaskService |
There was a problem hiding this comment.
Not asking for a change but I don't totally understand what the benefit of wrapping this in a class and making a singleton is?
There was a problem hiding this comment.
There is no reason, I just wanted to structure these better so I started with the tasks one and thought I'd keep adding similar things for the other services. I can remove that singleton from init if that is more preferable
…sformerlab/transformerlab-api into move/tasks-db-to-filesystem
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
2 participants
Depends on transformerlab/transformerlab-sdk#19