Show teams dropdown only when user info is available #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadmobile
previously approved these changes
Nov 21, 2025
deep1401
dismissed
dadmobile’s stale review
Sorry dismissing this one, could you re-review as I added one more condition which might be interesting to take a second look at
Member
|
Is the root cause of this that changes in the "teams" prop is not triggering a re-render in React? |
Member
Author
I think the root cause is that the authcontext sometimes provides current teams faster than the current user since current team is stored in localstorage |
Member
Author
|
@aliasaria An example of this, when I use the cloud launch but it hasn't fetched API yet. 
|
aliasaria
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue mentioned in the comment of #915