URI handling is now compatible with macOS#4
Open
yanntrividic wants to merge 1 commit intotranspect:masterfrom
Open
URI handling is now compatible with macOS#4yanntrividic wants to merge 1 commit intotranspect:masterfrom
yanntrividic wants to merge 1 commit intotranspect:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First of all, thank you for the
idml2xmlconverter, and for this frontend. This is great work, and opens up a lot of possibilities!! I have been playing around it for quite some time now, and it allowed me to make a custom Pandoc reader for IDML files, which helped me in various projects. So thank you, really.That being said, as mentioned #1 (comment),
idml2xml.shneeds to resolve canonical URIs. Additionally, there seems to be differentreadlinkversions out there, and even thoughidml2xml.shwas working on my Ubuntu 24.04 laptop, it did not work when I tried to test it on macOS (Sonoma 14.0), becausereadlinkreturns an empty string when called on a path that does not exist.This pull request fixes the problem. It adds standard URIs where it was crashing on macOS. Maybe some additional paths must also be turned into URIs, but it was enough to do the trick for me, and I am not sure if it is necessary everywhere, so I leave that there for now. I am pretty sure it is not as robust as what the comment mentions (i.e. using more recent Transpect libs) but as I do not know the codebase, I felt that this quick fix was better than nothing.
Have a nice day, and thank you again for this huge piece of work.