Skip to content

Commit b19e3a6

Browse files
committed
Remove dependency management updates from unsafe scripts
- Let Maven local repository provide custom artifacts - Allow BOM to manage tool versions (like protoc) - Avoid version conflicts in build process
1 parent aae3bed commit b19e3a6

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

.github/unsafe/build-custom-armeria.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,4 @@ mvn install:install-file -q \
3939
-Dversion="${CUSTOM_VERSION}" \
4040
-Dpackaging=jar
4141

42-
# Update dependencies
43-
DEPS="${SCRIPT_DIR}/../../dependencyManagement/build.gradle.kts"
44-
45-
# Update only the armeria core artifact version
46-
sed -i '/com\.linecorp\.armeria:armeria:/d' "${DEPS}"
47-
sed -i '/^val DEPENDENCIES = listOf(/a\ "com.linecorp.armeria:armeria:'"${CUSTOM_VERSION}"'",' "${DEPS}"
48-
4942
echo "armeria ${CUSTOM_VERSION} built and installed (UNSAFE disabled)."

.github/unsafe/build-custom-protobuf.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,4 @@ mvn install:install-file -q \
4141
-Dversion="${CUSTOM_VERSION}" \
4242
-Dpackaging=jar
4343

44-
# Update dependencies
45-
DEPS="${SCRIPT_DIR}/../../dependencyManagement/build.gradle.kts"
46-
sed -i '/com\.google\.protobuf:protobuf-java:/d' "${DEPS}"
47-
sed -i '/^val DEPENDENCIES = listOf(/a\ "com.google.protobuf:protobuf-java:'"${CUSTOM_VERSION}"'",' "${DEPS}"
48-
4944
echo "protobuf-java ${CUSTOM_VERSION} built and installed (UNSAFE disabled)."

0 commit comments

Comments
 (0)