Skip to content

pip.rb: python3 get-pip.py #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

pip.rb: python3 get-pip.py #1076

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89f8828
pip.rb: python3 get-pip.py
cclauss Apr 17, 2020
8c0c2da
Update cookbooks/travis_build_environment/recipes/pip.rb
cclauss Apr 22, 2020
3cdc83b
Merge branch 'master' into patch-1
cclauss Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cookbooks/travis_build_environment/recipes/pip.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
cwd Chef::Config[:file_cache_path]
code <<-INSTALL_PIP
python3 get-pip.py
python2 get-pip.py
python get-pip.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will break in Focal (it only provides python3, with an optional package symlinking python to it) but are still needed for images for older releases.

We can fix that when we get there though (in particular, we don't know if Travis will be providing the optional symlink), so not insisting on addressing this in this PR...

pip install --upgrade pip setuptools wheel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually necessary? If yes, why only run it for one of the pips?

INSTALL_PIP
not_if 'which pip'
Expand Down