Included a new recipe to install openjdk8 openj9 build #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will update the jdk_switcher script and create a PR. Once merged will update the jdk_switcher url in default attributes |
|
michaelklishin/jdk_switcher#15 - Updated the jdk_switcher script, but there is some issue with the tests run, have posted my queries in this PR |
|
Can someone review the changes please. |
|
@bogdanap - Can you please review this or get someone to review this. Thanks. |
Signed-off-by: Chandrakala <[email protected]>
|
I have updated the jdk_switcher url link with the commit level. It is more than 2 months since I have opened this PR, Can someone please review the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chandrakala [email protected]
What is the problem that this PR is trying to fix?
Included a recipe to install openjdk8 openj9 build available here - https://api.adoptopenjdk.net/
What approach did you choose and why?
How can you make sure the change works as expected?
I have tested my changes here
https://travis-ci.org/chandrams/test-cookbook
Would you like any additional feedback?