Skip to content

Conversation

ObserverOfTime
Copy link
Member

@ObserverOfTime ObserverOfTime commented May 8, 2025

Closes #157
Closes #179

@ObserverOfTime
Copy link
Member Author

Guess I'm gonna need some help with the rust bindings.

@ObserverOfTime ObserverOfTime marked this pull request as draft May 8, 2025 09:45
@JameeKim
Copy link

@ObserverOfTime Would you be interested in looking at my approach? Here's the commit page.

@ObserverOfTime
Copy link
Member Author

Would you mind submitting an issue upstream regarding this problem?

// This is needed because we need to pass in `ParseOptions` multiple times for the inline
// language. Since the struct contains `&mut`, it cannot implement `Clone` or `Copy`. We get
// around this by manually specifying that we mean to temporarily borrow all fields.
// This is obviously somewhat hacky. If `tree-sitter` adds fields to `ParseOptions` that are not
// `&mut`, this method might become implossible. Given this situation, the "proper" way to solve
// this problem seems to be changing the param type to `&mut ParseOptions` for
// `Parser::parse_with_options()` in upstream `tree-sitter` crate.

@ObserverOfTime ObserverOfTime marked this pull request as ready for review June 17, 2025 08:48
@ObserverOfTime ObserverOfTime force-pushed the update branch 2 times, most recently from e01f152 to 139de1e Compare June 17, 2025 09:03
@JameeKim
Copy link

Sure, I can do that today.

Btw, just FYI, the new options struct seems to be lacking a way for downstream users to construct it with non-default values.

ObserverOfTime and others added 3 commits June 17, 2025 20:26
- Disable grammar generation step
- Separate fuzz workflow from CI
- Drop duplicate release workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants