Fix UTF16 byte order + extend utf8 & utf16 test #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #40 by using
ByteOrder.nativeOrder()
.I changed
InputEncoding.valueOf
to acceptStandardCharsets.UTF_16BE
,StandardCharsets.UTF_16LE
andStandardCharsets.UTF_16
but ignore the endianness (to stay backwards compatible with e.g. a big-endian machine).I also changed the
parseUtf8
andparseUtf16
tests to verify that their small example code are actually parsed correctly.