Skip to content
This repository was archived by the owner on Nov 23, 2023. It is now read-only.

Conversation

ddeath
Copy link
Contributor

@ddeath ddeath commented Jun 26, 2018

This PR is for adding Cardano currency support and is intended to merge with trezor/trezor-core#250 and trezor/trezor.js#65

For the support of Cardano currency was required to add cardano-specific ed25519 crypto support.
The crypto code is based on cardano-crypto and cardano-sl - official Cardano repos.

We are NOT official developers of Cardano, however we are developers of www.cardanolite.com

@prusnak
Copy link
Member

prusnak commented Jun 26, 2018

Do not merge unless trezor/trezor-common#148 is merged first

@ddeath ddeath force-pushed the cardano branch 3 times, most recently from fbf637f to 261e111 Compare July 4, 2018 12:44
@ddeath
Copy link
Contributor Author

ddeath commented Aug 8, 2018

Hello, could you please update status on this PR. Do we have to do something to get this to merge? Thank you

@prusnak
Copy link
Member

prusnak commented Aug 8, 2018 via email

@szymonlesisz
Copy link
Contributor

szymonlesisz commented Aug 13, 2018

Ported to version 5. [PR] #186

A few changes was made:

  1. CardanoSignTransaction amounts should be a string
  2. Expected params and responses retyped from snake_case to camelCase
  3. CardanoGetPublicKey & CardanoGetAddress merged as one method "TrezorConnect.cardanoGetAddress"

Please see the docs and let me know what you think:

https://github.com/trezor/connect/blob/feature/cardano/docs/methods/cardanoGetAddress.md
https://github.com/trezor/connect/blob/feature/cardano/docs/methods/cardanoSignTransaction.md
https://github.com/trezor/connect/blob/feature/cardano/docs/methods/cardanoSignMessage.md
https://github.com/trezor/connect/blob/feature/cardano/docs/methods/cardanoVerifyMessage.md

@ddeath
Copy link
Contributor Author

ddeath commented Aug 14, 2018

@szymonlesisz first of all thank you for porting it to v5.

I suggest not to merge getAddress and getPublicKey because:

  • showOnTrezor paremeter will not work as the exporting of public key must be confirmed on trezor device, so bundling addresses to get them exported will not work as you will have to confirm exporting the key for each address
  • also public key is exporting hdPassphrase which is little bit sensitive - with this passphrase you will be able to tell if given address is belonging to the same wallet... if you do not have that passphrase you wont be able to say that. If the methods are merged, you will lost the ability to not share that passphrase

@ddeath
Copy link
Contributor Author

ddeath commented Aug 18, 2018

@szymonlesisz let me know what you think about that split to the getAddress and getPublicKey I can split it and create PR to your branch

@szymonlesisz
Copy link
Contributor

@ddeath ,
Yes, we agreed to split those two methods.
I've updated TrezorConnect code here

@ddeath
Copy link
Contributor Author

ddeath commented Aug 23, 2018

Closing this PR in favor of #186

@ddeath ddeath closed this Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants