-
-
Notifications
You must be signed in to change notification settings - Fork 317
refactor(e2e-suite): onboarding t1b1 create wallet #22221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(e2e-suite): onboarding t1b1 create wallet #22221
Conversation
packages/suite-desktop-core/e2e/support/pageObjects/settings/settingsPage.ts
Outdated
Show resolved
Hide resolved
packages/suite-desktop-core/e2e/support/pageObjects/settings/settingsPage.ts
Outdated
Show resolved
Hide resolved
packages/suite-desktop-core/e2e/tests/onboarding/t1b1/t1b1-create-wallet.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement of test value, there few existing methods and matchers that you can use here instead of creating new ones π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Extends the T1B1 onboarding end-to-end test to cover the full wallet creation flow including PIN setup, coin activation, and transition to the dashboard. Adds supporting page object helpers for coin activation state checks, PIN entry iteration, and a dashboard readiness locator.
- Adds full onboarding path: backup -> PIN -> asset activation -> finish
- Refactors PIN entry to handle multi-digit input sequentially
- Introduces helpers for verifying/activating coins and detecting wallet readiness
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/suite-desktop-core/e2e/tests/onboarding/t1b1/t1b1-create-wallet.test.ts | Extends test to complete full onboarding (PIN, coin activation, finish). |
packages/suite-desktop-core/e2e/support/pageObjects/trezorInput.ts | Refactors PIN entry to iterate digits sequentially. |
packages/suite-desktop-core/e2e/support/pageObjects/settings/settingsPage.ts | Adds coin button locator and method to assert activation state. |
packages/suite-desktop-core/e2e/support/pageObjects/dashboardPage.ts | Adds locator to assert wallet readiness after onboarding. |
34797b3
to
67907f4
Compare
67907f4
to
78de2fd
Compare
β
Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
β
Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
Description
Adding the steps to finish entire use case
ππ₯οΈ Suite web test results: View in Currents
ππ₯οΈ Suite desktop test results: View in Currents