Skip to content

Conversation

zako05
Copy link
Contributor

@zako05 zako05 commented Oct 6, 2025

Description

Adding the steps to finish entire use case

  • set up PIN
  • activate asset / coin
  • finish wallet creation

πŸ”πŸ–₯️ Suite web test results: View in Currents

πŸ”πŸ–₯️ Suite desktop test results: View in Currents

@zako05 zako05 self-assigned this Oct 6, 2025
Copy link
Contributor

@Vere-Grey Vere-Grey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement of test value, there few existing methods and matchers that you can use here instead of creating new ones πŸ‘

@Vere-Grey Vere-Grey requested a review from Copilot October 6, 2025 17:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Extends the T1B1 onboarding end-to-end test to cover the full wallet creation flow including PIN setup, coin activation, and transition to the dashboard. Adds supporting page object helpers for coin activation state checks, PIN entry iteration, and a dashboard readiness locator.

  • Adds full onboarding path: backup -> PIN -> asset activation -> finish
  • Refactors PIN entry to handle multi-digit input sequentially
  • Introduces helpers for verifying/activating coins and detecting wallet readiness

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/suite-desktop-core/e2e/tests/onboarding/t1b1/t1b1-create-wallet.test.ts Extends test to complete full onboarding (PIN, coin activation, finish).
packages/suite-desktop-core/e2e/support/pageObjects/trezorInput.ts Refactors PIN entry to iterate digits sequentially.
packages/suite-desktop-core/e2e/support/pageObjects/settings/settingsPage.ts Adds coin button locator and method to assert activation state.
packages/suite-desktop-core/e2e/support/pageObjects/dashboardPage.ts Adds locator to assert wallet readiness after onboarding.

@Vere-Grey Vere-Grey force-pushed the test/refactor-onboarding-t1b1-create-wallet branch from 34797b3 to 67907f4 Compare October 6, 2025 17:23
@zako05 zako05 force-pushed the test/refactor-onboarding-t1b1-create-wallet branch from 67907f4 to 78de2fd Compare October 10, 2025 12:11
@trezor-bot
Copy link
Contributor

trezor-bot bot commented Oct 10, 2025

βœ… Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
πŸ’‘ If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@trezor-bot
Copy link
Contributor

trezor-bot bot commented Oct 10, 2025

βœ… Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
πŸ’‘ If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@HajekOndrej HajekOndrej requested a review from Vere-Grey October 10, 2025 12:37
Copy link
Contributor

@Vere-Grey Vere-Grey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@Vere-Grey Vere-Grey merged commit e7c3881 into develop Oct 14, 2025
28 checks passed
@Vere-Grey Vere-Grey deleted the test/refactor-onboarding-t1b1-create-wallet branch October 14, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants