Refactor: entropy thunks cleanup #22382

Lemonexe · 2025-10-10T09:24:49Z

Description

refactor mobile createAndBackupWalletThunk
- fullfill/reject with value instead of return/throw
- move navigation side-effect to React
unify a key part of entropy check result handling to suite-common

QA instructions

Test the happy path:

mobile device onboarding
mobile device onboarding after partial onboarding in web (wallet created but backup not done)
web device onboarding

If possible, test both with a device that does not pass entropy check.

Screenshots:

ℹ️ entropy check failure tested with the testing branch

mobile entropy success.webm
mobile entropy fail.webm
mobile entropy check disabled.webm (via local message system)
mobile initiating backup.webm (device needs backup after partial onboarding in suite)
desktop entropy success.webm
desktop entropy fail.webm
desktop entropy disabled.webm

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

🔍🖥️ Suite native android test results: View in Currents

suite-common/wallet-core/src/device/deviceThunks.ts

suite-native/device/src/deviceThunks.ts

Lemonexe · 2025-10-10T09:45:52Z

suite-native/module-device-onboarding/src/screens/WalletCreationScreen.tsx

+
+    const isEntropyCheckEnabled = useSelector((state: MessageSystemRootState) =>
+        selectIsFeatureEnabled(state, Feature.entropyCheckMobile, true),
+    );


extracting .navigate side-effect from the thunk to React means that I have to duplicate the condition for isEntropyCheckEnabled but that's acceptable I guess.

suite-native/module-device-onboarding/src/screens/WalletCreationScreen.tsx

trezor-bot · 2025-10-10T09:49:19Z

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

trezor-bot · 2025-10-10T09:49:21Z

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

Lemonexe · 2025-10-10T09:55:42Z

suite-common/wallet-core/src/device/deviceThunks.ts

+            dispatch(failEntropyCheckThunk({ device, error: result.payload }));
+        }
+    },
+);


⚠️ pls careful CR, this is a really key part where a lot can go wrong.
I copied the implementation from suite.
Unifying it will lower the surface for future human mistakes 🙂

suite-common/wallet-core/src/device/deviceThunks.ts

juriczech · 2025-10-16T12:06:23Z

suite-native/module-device-onboarding/src/screens/WalletCreationScreen.tsx

-            ) {
+            const { code } = responsePayload.payload;
+            if (code && DEFINITIVE_ERRORS.includes(code)) {
+                if (isEntropyCheckEnabled && code === 'Failure_EntropyCheck') {


nitpick: I think what's not ideal is that we could simply return the value of failEntropyCheckThunk all the way to the result of createAndBackupWalletThunk and by doing that, we wouldn't have to store it in the state and select it here and just look at the type of return value to see whether it's the "correct" error. Again, out of scope for this PR for sure.

Good idea. Together with your comment above it's a good followup for a next PR in future.

juriczech

Overall LGTM, just some nitpick comments for discussion that shouldn't be blockers.

Mobile success works as expected. Tested error on branch FW-check-UI-testing-branch where I "succesfully" get redirected to DeviceCompromisedModal screen 💪

Lemonexe added this to Suite Mobile Oct 10, 2025

Lemonexe added the mobile Suite Lite issues and PRs label Oct 10, 2025

Lemonexe added this to Suite Desktop Oct 10, 2025

github-project-automation bot moved this to 🎯 To do in Suite Mobile Oct 10, 2025