feat(suite): display the progress bar when the trezor is done updatin… #22397

vojtatranta · 2025-10-10T12:22:03Z

…g and waiting for restart

Description

Related Issue

Resolve #22256
Resolve #22257

Screenshots:

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

🔍🖥️ Suite native android test results: View in Currents

vojtatranta · 2025-10-10T12:22:35Z

packages/suite/src/components/firmware/FirmwareProgressBar.tsx

-    if (uiEvent?.type === 'ui-firmware_reconnect') {
+    const isDone = progress === 100;
+
+    if (uiEvent?.type === 'ui-firmware_reconnect' && !isDone) {


I kept this condition, coz I am not sure why is it here. But I keep rendering the progress when the installation is done

I'll try to remove the condition completely

suite-common/firmware/src/hooks/useFirmwareInstallation.ts

trezor-bot · 2025-10-13T07:56:21Z

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

trezor-bot · 2025-10-13T07:56:22Z

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

vojtatranta · 2025-10-13T10:25:55Z

suite-common/firmware/src/hooks/useFirmwareInstallation.ts

+            return {
+                operation: 'restarting',
+                // NOTE: when restarting to the normal mode, assume that the installation is finished
+                progress: restartingToNormalModeAfterInstallation ? 100 : 0,


Altough, this works fine on Desktop, I will check the mobile if it doesn't break anything. I could put ti to mine userDesktopFirmwareIInstallation

vojtatranta · 2025-10-13T12:12:15Z

packages/suite/src/hooks/suite/useFirmwareDesktopUpdate.ts

        firmwareUpdate: desktopFirmwareUpdate,
        toggleLowBatteryModal: useCallback(() => setShowLowBatteryModal(prev => !prev), []),
        showLowBatteryModal,
+        reconnectEvent,


so this is only for desktop, it is not the pretiest, but prevetns problem with mobile guys

vojtatranta · 2025-10-13T12:12:52Z

packages/suite/src/views/firmware/FirmwareModal.tsx

    return (
        <Modal.Backdrop onClick={isCancelable ? handleClose : undefined}>
-            {showConfirmationPill && (
-                <ConfirmOnDevicePill


I am removing the pill here @jvaclavik which I hope it is correct. The Device sercuirty check is within <OnboardinCard> and that has got its own pill

I don't understand this comment. This has nothing to do with onboarding, since this only affects the firmware installation in settings, not the one in onboarding, no?

Yeah, but @jvaclavik mentioned it on Slack taht this pill is used in the onboarding. So I was ensuring that this usage of the pill is only within the update context.

Still don't get it. This pill has to be used anywhere there's device action required, it has nothing to do with onboarding.

It has to do with onboardin that it is also used in onboardin eg. in the security check. But Komar requested this pill to be removed from the FW update steps because these steps are handled with modals.

So I did that. ANd here I am making sure that the pill is only removed from the FW update, and not from eg. security check in onboarding.

@vojtatranta could you please add video of passing through the firmware install?

"But Komar requested this pill to be removed from the FW update steps because these steps are handled with modals." This doesn't make sense. The pill has to remain, it is present in all modals requiring device action.

It does make sense in the Firmware update modal, because there the actions required on the device are replaced with the modals.

I get it now, sorry!

vojtatranta · 2025-10-13T12:50:29Z

packages/suite/src/components/firmware/FirmwareProgressBar.tsx

        completed: 'TR_FIRMWARE_STATUS_INSTALLATION_COMPLETED',
    };

-    if (uiEvent?.type === 'ui-firmware_reconnect') {


FYI: I am looking if this won't break anything

looks fine @komret objections, ideas?

vojtatranta · 2025-10-13T12:54:51Z

packages/suite/src/hooks/suite/useFirmwareDesktopUpdate.ts


+    const restartingToBootloader = reconnectEvent && reconnectEvent.target === 'bootloader';
+
+    const updateOperation: FirmwareOperationStatus =


no the prettiest, but workign safely (won't affect mobile)

vojtatranta · 2025-10-14T08:12:16Z

I tested also when connected via USB and it looks good.

jvaclavik · 2025-10-14T12:06:22Z

packages/suite/src/support/messages.ts

    },
-    TR_RESTARTING_TREZOR_ENTER_PIN_IF_NEEDED: {
-        defaultMessage: 'Restarting Trezor. Enter PIN if prompted.',
+    TR_RESTARTING_TREZOR_ENTER_PIN_WHEN_NEEDED: {


isn't it pity to loose all the translations because of this?

Suggesting use it only in crowdin

well, the text means somethign different now. I think overriding the original makes sense right now. There is also "IF" in the text.

jvaclavik · 2025-10-14T12:45:36Z

packages/suite/src/views/firmware/FirmwareModal.tsx

    return (
        <Modal.Backdrop onClick={isCancelable ? handleClose : undefined}>
-            {showConfirmationPill && (
-                <ConfirmOnDevicePill


No idea, I went through onboarding and it looked OK, but not sure if there is also this screen 🤷‍♂️

jvaclavik · 2025-10-14T12:46:32Z

Why is trezor missing here?

do you use getDeviceInternalModel ?

vojtatranta · 2025-10-14T12:47:18Z

Why is trezor missing here?

do you use getDeviceInternalModel ?

yes, that's the same code , but I think the device is litearlly not available at that moment. There is no device as it is restarting - guess

vojtatranta · 2025-10-15T07:59:57Z

Why is trezor missing here?
do you use getDeviceInternalModel ?

yes, that's the same code , but I think the device is litearlly not available at that moment. There is no device as it is restarting - guess

@jvaclavik in which scenario trezore disapears? I tried it now and it didn't disapear?

jvaclavik · 2025-10-15T08:21:47Z

@jvaclavik in which scenario trezore disapears? I tried it now and it didn't disapear?

I don't know, I saw it in your screenshot above 😅

vojtatranta · 2025-10-15T08:22:26Z

@jvaclavik in which scenario trezore disapears? I tried it now and it didn't disapear?

I don't know, I saw it in your screenshot above 😅

ah, cool, I am removing that, so it is on the pill in the modal, cool.

…g and waiting for restart

…100 before instalation starts

…ate modal

vojtatranta requested a review from pavelmario as a code owner October 10, 2025 12:22

vojtatranta requested a review from komret October 10, 2025 12:22

vojtatranta commented Oct 10, 2025

View reviewed changes

vojtatranta force-pushed the 22256-improvement-restarting-device branch 3 times, most recently from ba6cf38 to b5a919b Compare October 10, 2025 13:01

vojtatranta commented Oct 13, 2025

View reviewed changes

suite-common/firmware/src/hooks/useFirmwareInstallation.ts Outdated Show resolved Hide resolved

vojtatranta force-pushed the 22256-improvement-restarting-device branch from b5a919b to eef217c Compare October 13, 2025 07:56

vojtatranta marked this pull request as draft October 13, 2025 09:47

vojtatranta force-pushed the 22256-improvement-restarting-device branch from eef217c to 93b948b Compare October 13, 2025 10:24

vojtatranta commented Oct 13, 2025

View reviewed changes

vojtatranta force-pushed the 22256-improvement-restarting-device branch 7 times, most recently from 82e7b04 to 3394a61 Compare October 13, 2025 12:05

vojtatranta requested a review from jvaclavik October 13, 2025 12:11

vojtatranta commented Oct 13, 2025

View reviewed changes

vojtatranta force-pushed the 22256-improvement-restarting-device branch 2 times, most recently from ba64db7 to e112215 Compare October 13, 2025 12:32

vojtatranta commented Oct 13, 2025

View reviewed changes

vojtatranta marked this pull request as ready for review October 13, 2025 12:55

vojtatranta force-pushed the 22256-improvement-restarting-device branch from e112215 to 7ebc047 Compare October 13, 2025 13:22

vojtatranta mentioned this pull request Oct 13, 2025

Better indication that firmware installation is done #22257

Open

vojtatranta force-pushed the 22256-improvement-restarting-device branch 2 times, most recently from 491cb4c to 93e114b Compare October 14, 2025 07:49

vojtatranta requested a review from a team October 14, 2025 08:12

vojtatranta mentioned this pull request Oct 14, 2025

Confirmation pill glitches before firmware installation #22336

Open

jvaclavik reviewed Oct 14, 2025

View reviewed changes

vojtatranta force-pushed the 22256-improvement-restarting-device branch from 93e114b to b155c53 Compare October 15, 2025 08:16

vojtatranta requested a review from jvaclavik October 15, 2025 12:00

vojtatranta added 3 commits October 15, 2025 14:01

feat(suite): display the progress bar when the trezor is done updatin…

96f3850

…g and waiting for restart

fix(suite): ensure that the firmware update progress bar doesnt show …

b4d821f

…100 before instalation starts

fix(suite): remove the confirm on device pill from the desktop fw upd…

59d68c9

…ate modal

vojtatranta force-pushed the 22256-improvement-restarting-device branch from b155c53 to 59d68c9 Compare October 15, 2025 12:01

vojtatranta requested a review from seibei-iguchi October 15, 2025 13:23

seibei-iguchi approved these changes Oct 15, 2025

View reviewed changes


		const restartingToBootloader = reconnectEvent && reconnectEvent.target === 'bootloader';

		const updateOperation: FirmwareOperationStatus =

Uh oh!

feat(suite): display the progress bar when the trezor is done updatin… #22397

Are you sure you want to change the base?

feat(suite): display the progress bar when the trezor is done updatin… #22397

Conversation

vojtatranta commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Screenshots:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trezor-bot bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trezor-bot bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vojtatranta commented Oct 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jvaclavik commented Oct 14, 2025

Uh oh!

vojtatranta commented Oct 14, 2025

Uh oh!

vojtatranta commented Oct 15, 2025

Uh oh!

jvaclavik commented Oct 15, 2025

Uh oh!

vojtatranta commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vojtatranta commented Oct 10, 2025 •

edited

Loading

trezor-bot bot commented Oct 13, 2025 •

edited

Loading

trezor-bot bot commented Oct 13, 2025 •

edited

Loading