-
-
Notifications
You must be signed in to change notification settings - Fork 317
chore(suite-native): expo 54: dependencies update #22402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
40ea992
to
99b88a3
Compare
/rebase |
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/18465416511 |
99b88a3
to
1605ca7
Compare
312082e
to
c2d2b11
Compare
c2d2b11
to
af97a65
Compare
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
e2c92e9
to
f25ab6b
Compare
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
396ae0b
to
090655c
Compare
090655c
to
1881983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need this, or not? https://github.com/expo/fyi/blob/main/expo-54-reanimated.md#using-sdk-54-with-legacy-architecture
I belive we should use it and also update react-native-reanimated to latest v3 version 3.19.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some new warnings in the console:
WARN Deep imports from the 'react-native' package are deprecated ('react-native/Libraries/Text/TextNativeComponent'). Source: ~/Projects/trezor-suite/suite-native/atoms/src/Text.tsx 12:0 [Stack]
WARN Deep imports from the 'react-native' package are deprecated ('react-native/Libraries/Text/TextNativeComponent'). Source: ~/Projects/trezor-suite/suite-native/icons/src/Icon.tsx 6:0 [Stack]
Followup?
There is also new deprecations of SafeAreaView imported directly from react-native, we have that on one place in ConfirmOnTrezorImage, but that is definitely for follow-up PR.
Description
Out of the Scope of this PR:
List of updated deps:
Related Issue
Resolve #22364
Screenshots:
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents