Skip to content

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Sep 20, 2024

Replaces #657

Also adjusts eslint configuration

Bumps eslint from 8.57.0 to 9.10.0.


updated-dependencies:

  • dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ...

Co-autored-by: Manfred Moser [email protected]

dependabot bot and others added 2 commits September 24, 2024 09:23
Also adjusts eslint configuration

Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.10.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.57.0...v9.10.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-autored-by: Manfred Moser <[email protected]>
@regadas regadas merged commit 3bef09f into trinodb:main Sep 24, 2024
4 checks passed
@mosabua mosabua deleted the eslint branch September 24, 2024 17:00
@yu-iskw
Copy link

yu-iskw commented Nov 13, 2024

@mosabua @regadas I encountered the subsequent issue with v0.2.4 in @lightdash/cli. I am assuming that the error is caused by adding "type": "module" to package.json. I am not familiar with JS/ES/TS very much. Can I have advice to solve this?

lightdash/lightdash#12387

$ lightdash
/Users/yu/.anyenv/envs/nodenv/versions/20.10.0/lib/node_modules/@lightdash/cli/node_modules/@lightdash/warehouses/dist/warehouseClients/TrinoWarehouseClient.js:8
const trino_client_1 = require("trino-client");
                       ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/yu/.anyenv/envs/nodenv/versions/20.10.0/lib/node_modules/@lightdash/cli/node_modules/trino-client/dist/index.js from /Users/yu/.anyenv/envs/nodenv/versions/20.10.0/lib/node_modules/@lightdash/cli/node_modules/@lightdash/warehouses/dist/warehouseClients/TrinoWarehouseClient.js not supported.
index.js is treated as an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which declares all .js files in that package scope as ES modules.
Instead either rename index.js to end in .cjs, change the requiring code to use dynamic import() which is available in all CommonJS modules, or change "type": "module" to "type": "commonjs" in /Users/yu/.anyenv/envs/nodenv/versions/20.10.0/lib/node_modules/@lightdash/cli/node_modules/trino-client/package.json to treat all .js files as CommonJS (using .mjs for all ES modules instead).

    at Object.<anonymous> (/Users/yu/.anyenv/envs/nodenv/versions/20.10.0/lib/node_modules/@lightdash/cli/node_modules/@lightdash/warehouses/dist/warehouseClients/TrinoWarehouseClient.js:8:24) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v20.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants