Support other AuthTypes in addition to BasicAuth #755
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
3 similar comments
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Hi @nakulgan can you sign the CLA? |
| const trino = Trino.create({ | ||
| catalog: 'tpcds', | ||
| schema: 'sf100000', | ||
| auth: new OAuth2Auth('token'), |
There was a problem hiding this comment.
we need to update cluster config to have a proper test for this
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Could you please submit a CLA @nakulgan ... we can not merge before that. And we need some tests added. |
|
Hi there 👋 I started looking getting OAuth to work for the Trino Driver SQLTools VS Code Extension and realised the capability isn't in @nakulgan any chance you could try make the changes to get this merged in? Happy to help set up any testing or contribute in any way I can. This would be a massive help if this was to get merged in! |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Fixes #524 --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/trinodb/trino-js-client/issues/524?shareId=XXXX-XXXX-XXXX-XXXX).
* **src/index.ts** - Add `OAuth2Auth` class implementing the `Auth` interface - Update `Client.create` method to handle `OAuth2Auth` authentication type - Remove other authentication types except `BasicAuth` and `OAuth2Auth` * **README.md** - Update "Features" section to mention support for Basic and OAuth2 authentication types - Add examples for using `OAuth2Auth` in the "Usage" section * **tests/it/client.spec.ts** - Add integration tests for `OAuth2Auth` authentication type
…ntication * **OAuth2Auth class** - Add new class `OAuth2Auth` implementing the `Auth` interface for OAuth2 authentication - Add support for additional properties: `clientId`, `clientSecret`, `refreshToken`, `tokenEndpoint` * **Client.create method** - Update to handle the new `OAuth2Auth` authentication type - Remove other authentication types except `BasicAuth` and `OAuth2Auth` * **README.md** - Update example for using the new `OAuth2Auth` authentication type
* Add `scopes`, `tokenType`, `expiresIn`, `redirectUri`, and `grantType` properties to `OAuth2Auth` class * Update `Client.create` method to handle new properties in `OAuth2Auth` authentication type
- Restore accidentally removed Query type definition - Fix linting errors with lexical declarations in switch cases - Add comprehensive unit tests for BasicAuth and OAuth2Auth classes - Update package.json to include unit test script - All tests now pass successfully
nakulgan
force-pushed
the
support-auth-types
branch
from
7fcfb8b to
b8feb7e
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Unfortunately we never received a signed CLA so we can not proceed with merging or using this material |
Fixes #524