Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 2, 2025

This pull request changes the compat entry for the DataStructures package from 0.18.15 to 0.18.15, 0.19.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2025-08-02-00-05-18-390-00851208568 branch from 044d166 to 66da0b9 Compare August 2, 2025 00:05
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.76%. Comparing base (e34b0e0) to head (dcca56c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2512   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files         518      518           
  Lines       42400    42400           
=======================================
  Hits        41027    41027           
  Misses       1373     1373           
Flag Coverage Δ
unittests 96.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Aug 10, 2025

We need to wait for SciML/OrdinaryDiffEq.jl#2817 to test the new version.
Edit: Now it is SciML/OrdinaryDiffEq.jl#2841.

@JoshuaLampert JoshuaLampert marked this pull request as draft August 10, 2025 12:25
@JoshuaLampert
Copy link
Member

OrdinaryDiffEq.jl updated the versions in SciML/OrdinaryDiffEq.jl#2847, but we need to wait for new releases.

@JoshuaLampert JoshuaLampert marked this pull request as ready for review September 7, 2025 08:38
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datastructures.jl v0.19 is used in the tests.

@ranocha ranocha enabled auto-merge (squash) September 8, 2025 06:15
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha merged commit c0d8766 into main Sep 8, 2025
39 checks passed
@ranocha ranocha deleted the compathelper/new_version/2025-08-02-00-05-18-390-00851208568 branch September 8, 2025 06:47
sbairos pushed a commit to sbairos/Trixi.jl that referenced this pull request Sep 11, 2025
…compat) (trixi-framework#2512)

* CompatHelper: bump compat for DataStructures to 0.19, (keep existing compat)

* Update Project.toml

* Update Project.toml

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants