CS-218 [Improvement] - Ability to log findings within the People section

[github-actions]

This is an automated pull request to merge chas/people-findings into dev.
It was created by the [Auto Pull Request] action.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app	Ready	Preview, Comment	Apr 13, 2026 6:35pm
comp-framework-editor	Ready	Preview, Comment	Apr 13, 2026 6:35pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
portal	Skipped		Apr 13, 2026 6:35pm

[cursor]

PR Summary

Medium Risk
Adds a new persisted Finding.scope enum with new API query modes and notification routing, which can affect data queries and who gets alerted. Risk is moderate due to schema migration and changed deep-link/recipient logic, though changes are scoped to findings.

Overview
Adds a new FindingScope enum and nullable Finding.scope column, allowing findings to be created and queried for People-area contexts (not tied to tasks or documents).

Extends the findings API to support scope and hasScope=true queries, updates creation validation to allow scope as the sole target, and records findingScope in audit logs.

Updates notification generation to handle scope-based findings (People deep link + scope titles) and changes recipient resolution so scope findings notify org owners/admins; adds a new People "Findings" tab UI backed by GET /v1/findings?hasScope=true, including scope filtering, scope badges, and create-finding support with a scope selector.

^{Reviewed by Cursor Bugbot for commit 5d5a167. Bugbot is set up for automated code reviews on this repo. Configure here.}

[mintlify]

Preview deployment for your docs. Learn more about Mintlify Previews.

Project	Status	Preview	Updated (UTC)
CompAI	🟢 Ready	View Preview	Apr 8, 2026, 1:09 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

[linear]

CS-218 [Improvement] - Ability to log findings within the People section

[tofikwest]

@chasprowebdev In PeoplePageTabs, tab state comes from Tabs defaultValue based on searchParams. defaultValue is only used on first mount, so if URL changes client-side to /people?tab=findings, the active tab may stay on the previous tab.

Result: user opens a Findings deep link but still sees People tab.

Can we switch this to controlled tabs (value + onValueChange) so UI always follows the URL?

[Marfuen]

@cubic-dev-ai review this pull request

[cubic-dev-ai]

@cubic-dev-ai review this pull request

@Marfuen I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

1 issue found across 22 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/api/src/findings/finding-audit.service.ts">

<violation number="1" location="apps/api/src/findings/finding-audit.service.ts:24">
P2: `logFindingDeleted` was not updated to include the new `findingScope` field. If the scope is important enough to audit on creation, it should also be captured on deletion for a complete audit trail.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[tofikwest]

@cubic-dev-ai review this

[cubic-dev-ai]

@cubic-dev-ai review this

@tofikwest I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

1 issue found across 22 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/app/src/app/(app)/[orgId]/people/all/components/PeopleFindingsList.tsx">

<violation number="1" location="apps/app/src/app/(app)/[orgId]/people/all/components/PeopleFindingsList.tsx:181">
P2: Grammar bug: "requires action" should be "require action" when the count is plural (e.g., "3 requires action" → "3 require action").</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{Requires human review: Contains database migrations and significant changes to core business logic (findings creation, notifications, and API filtering) which require human review.}

[chasprowebdev]

@cubic-dev-ai review this

[cubic-dev-ai]

@cubic-dev-ai review this

@chasprowebdev I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 22 files

_{Requires human review: This PR includes a database migration, API changes, and significant business logic updates across multiple services, which requires human review according to the established guidelines.}