Conversation
[dev] [carhartlewis] lewis/comp-email-template-fix
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Adds Vitest-based regression tests ( Reviewed by Cursor Bugbot for commit 3376196. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3376196. Configure here.
| changedByName="Admin" | ||
| /> | ||
| ), | ||
| }, |
There was a problem hiding this comment.
Test passes wrong props to TaskStatusNotificationEmail
Medium Severity
The regression test for TaskStatusNotificationEmail passes props (oldStatus, newStatus, organizationId, taskId, changedByName) that don't exist in the component's Props interface. The actually required props taskStatus and taskUrl are never provided. Since vitest uses esbuild which strips types, this test silently runs with undefined for both, giving false confidence that the component renders correctly while not actually testing it with valid data.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3376196. Configure here.
| policyId="p1" | ||
| isUpdate={false} | ||
| /> | ||
| ), |
There was a problem hiding this comment.
Test passes wrong props to PolicyNotificationEmail
Medium Severity
The regression test for PolicyNotificationEmail passes policyId and isUpdate which don't exist in the component's Props interface, and omits the required notificationType prop (typed as 'new' | 'updated' | 're-acceptance'). At runtime, notificationType is undefined, so the switch always hits the default case. The test silently passes but doesn't validate the component with valid inputs.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3376196. Configure here.
1 participant
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.