Skip to content

Complete ROS2 migration: ProfilePublisher, StatsPublisher, and liveprofile#23

Draft
Copilot wants to merge 6 commits intoros2from
copilot/fix-ros2-migration-issues
Draft

Complete ROS2 migration: ProfilePublisher, StatsPublisher, and liveprofile#23
Copilot wants to merge 6 commits intoros2from
copilot/fix-ros2-migration-issues

Conversation

Copy link

Copilot AI commented Feb 4, 2026

Completes ROS2 migration of remaining ROS1 components. ProfilePublisher and StatsPublisher now accept rclcpp::Node* for integration into downstream libraries.

C++ Publishers

API Change: Both publishers now require node pointer injection:

// ROS1
ProfilePublisher publisher(profiler);

// ROS2
ProfilePublisher publisher(profiler, node_ptr);
  • Replaced ros::Publisherrclcpp::Publisher<T>::SharedPtr
  • Replaced ros::NodeHandlerclcpp::Node* parameter
  • Updated message types: std_msgs::Stringstd_msgs::msg::String

Python Script

Migrated scripts/liveprofile:

  • rospyrclpy with Node inheritance
  • Time handling: rospy.get_rostime()self.get_clock().now()
  • Python 3 compatibility fixes

Build System

  • Added rclpy exec dependency
  • Exported rosidl_default_runtime
  • Added ament_lint_auto support
  • Installed Python script

Documentation

  • Updated README with ROS2 usage patterns
  • Added .gitignore for ROS2 build artifacts
Original prompt

Check whether the changes I already made are correct for migrating to ROS2. Also convert all code to ROS2. Keep in mind the ProfilePublisher should be usable by other libraries. In the way of execution the user wants. Also pay attention to doc generation, testing, linting including linting of CMakeLists and package.xml


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 5 commits February 4, 2026 06:53
Co-authored-by: MatthijsBurgh <18014833+MatthijsBurgh@users.noreply.github.com>
Co-authored-by: MatthijsBurgh <18014833+MatthijsBurgh@users.noreply.github.com>
Co-authored-by: MatthijsBurgh <18014833+MatthijsBurgh@users.noreply.github.com>
Co-authored-by: MatthijsBurgh <18014833+MatthijsBurgh@users.noreply.github.com>
Co-authored-by: MatthijsBurgh <18014833+MatthijsBurgh@users.noreply.github.com>
Copilot AI changed the title [WIP] Check and convert code for ROS2 migration Complete ROS2 migration: ProfilePublisher, StatsPublisher, and liveprofile Feb 4, 2026
Copilot AI requested a review from MatthijsBurgh February 4, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants