sort project references as xcode16 #867
Conversation
Speakus
changed the title
pepicrft
force-pushed
the
m.kholyavkin/IOSC-12423-sort-projectReferences-as-xcode16
branch
from
9459faf to
61391f4
Compare
pepicrft
left a comment
pepicrft
left a comment
There was a problem hiding this comment.
Let's add some tests to ensure no regressions are introduced in this area.
|
|
||
| for project in projects { | ||
| /// The project references are sorted alphabetically based on the name of the project it's being referenced. | ||
| project.projectReferences = project.projectReferences.sorted(by: { lhs, rhs in |
There was a problem hiding this comment.
@Speakus in which scenario a project contains more than one project reference. Would you mind adding a fixture under Fixtures so that we can add some tests?
There was a problem hiding this comment.
hi. I changed company where I work and It's not so easy for me anymore to provide some example.
@mikhailmulyar may you help with Fixtures?
There was a problem hiding this comment.
yes, will try to provide some example
There was a problem hiding this comment.
Here it is, I've added example with wrong ordering and some tests for checking.
mikhailmulyar@4f282f1
There was a problem hiding this comment.
@mikhailmulyar would you mind completing this PR? It'll require closing this one and opening a new one.
3 participants
Short description 📝
If project saved with XcodeProj then opening it with Xcode 16 generate some changes. So we could respect Xcode 16 sorting by sorting our result with the same way.
Solution 📦
Do the same sorting as Xcode 16 do
NB! This PR based on other fix so please merge this PR first #865