Skip to content

Conversation

@2sem
Copy link

@2sem 2sem commented Mar 27, 2025

Resolves https://github.com/tuist/xcodeproj/issues/6914

Short description 📝

Fix Fastlane error
update_code_signing_settings
Seems to be a very old project file format - please open your project file in a more recent version of Xcode
fastlane/fastlane#22187

Solution 📦

Add TargetAttributes even if it is empty

Implementation 👩‍💻👨‍💻

revert last commit of #865

스크린샷 2025-03-27 오후 9 00 15

Test

  • [✓] Install new XcodeProj into Tuist
    • 스크린샷 2025-03-31 오후 7 40 34
  • [✓] Generate App with modified Tuist.
    • 스크린샷 2025-03-31 오후 7 50 16
  • [✓] Find Empty TargetAttribute in the .pbxroj
    • 스크린샷 2025-03-31 오후 7 52 36

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 27, 2025
@2sem 2sem force-pushed the fix-fastlane-missing-TargetAttributes branch from b540117 to 8f6f225 Compare March 28, 2025 14:50
@2sem
Copy link
Author

2sem commented Mar 28, 2025

I fixed commit message

@fortmarek
Copy link
Member

Hey @2sem, thanks a lot for the PR. I'm closing this one as @MouadBenjrinija created a PR for the same fix, but it included also the necessary unit test changes. #924

@fortmarek fortmarek closed this Apr 7, 2025
@2sem
Copy link
Author

2sem commented Apr 8, 2025

Hey @2sem, thanks a lot for the PR. I'm closing this one as @MouadBenjrinija created a PR for the same fix, but it included also the necessary unit test changes. #924

yeah I didn't know that
if the PR ran test, I could noticed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants