Set and remove element aria-describedby base on popper#90
Open
tuanthieu2993 wants to merge 1 commit intotvkhoa:masterfrom
Open
Set and remove element aria-describedby base on popper#90tuanthieu2993 wants to merge 1 commit intotvkhoa:masterfrom
tuanthieu2993 wants to merge 1 commit intotvkhoa:masterfrom
Conversation
To fix aria attribute do not have valid value, issue: https://github.com/tvkhoa/react-tippy/issues/89 As describedby need to point to a valid id, that means id that exists, while current implementation set it from beginning and keep it there even when the popper is hidden - removed from DOM. This update will help solve issue as we only set it when show and remove when hide the popper
tvkhoa
approved these changes
Oct 3, 2018
|
Hi @tvkhoa, this fix was approved. Will this be merged and released soon? Thanks! |
|
bueller? This is breaking aXe tests and I'd like to re-enable them |
|
Hello guys, I recommend switching to https://github.com/atomiks/tippy.js-react It's the official package and it's totally a11y compliance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To fix aria attribute do not have valid value, issue: https://github.com/tvkhoa/react-tippy/issues/89
As describedby need to point to a valid id, that means id that exists, while current implementation set it from beginning and keep it there even when the popper is hidden - removed from DOM.
This update will help solve issue as we only set it when show and remove when hide the popper
Screenshots
When page is init with tooltipped elements
When popper is shown
When popper is hidden
