Skip to content

Passkeys backend improvements/fixes for code exchange #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2024
Merged

Passkeys backend improvements/fixes for code exchange #573

merged 2 commits into from
Oct 11, 2024

Conversation

robinske
Copy link
Collaborator

Description

  • Adds axios as a dependency
  • Sets default API_URL
  • improves README

Checklist

  • I ran npm test locally and it passed without errors.
  • I acknowledge that all my contributions will be made under the project's license.

Related issues

@robinske robinske requested review from bnb and pkamp3 October 11, 2024 12:47
pkamp3
pkamp3 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@pkamp3 pkamp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@robinske robinske merged commit d7bb665 into main Oct 11, 2024
2 checks passed
@robinske robinske deleted the passkeys branch October 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkamp3 pkamp3 pkamp3 approved these changes

@bnb bnb Awaiting requested review from bnb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robinske @pkamp3