Fix TypeScript named import typing issue - resolves 'any' type for destructured imports #1108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #935 where
import { Twilio } from "twilio/lib"
resulted in theTwilio
constructor being typed asany
instead of the properTwilio
type, causing TypeScript to lose type safety and intellisense support.Root Cause
The issue occurred because the generated TypeScript definitions in
lib/index.d.ts
used theexport = TwilioSDK
syntax with namespace declarations that contained both type and value declarations with the same names. When TypeScript tried to resolve named imports like{ Twilio }
from modules usingexport =
, it couldn't properly infer the correct type and fell back toany
.Before (Broken)
After (Fixed)
Solution
Enhanced the generated TypeScript definitions in
lib/index.d.ts
to provide proper value declarations in the namespace alongside the existing type declarations. This enables TypeScript to correctly resolve named imports while maintaining full backward compatibility with existing CommonJS usage patterns.The fix:
export = TwilioSDK
for CommonJS compatibilityimport { Twilio }
to the correct constructor typeTesting
This change resolves the frustrating developer experience issue where users lost type safety when using the more modern destructuring import syntax, while ensuring no breaking changes for existing code.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.