feat(tio-tool): Change RPC getopts style from FloatingFrees to StopAtFirstFree #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
getoptsin its defaultFloatingFreesmod treats negative RPC arguments (e.g.,-1) as flags when users invoke:Based on our help text, users place
[rpc-arg]immediately after<rpc-name>and thus the parsing style should be changed toStopAtFirstFree. This no longer requires marking--to stop searching for flags (shown below).Changes
tio-tool'srpc()togetopts::ParsingStyle::StopAtFirstFreeso everything after<rpc-name>is treated as free (fixes negative args without requiring--).util::default_proxy_url()as the actual fallback for-r--rep-type(not--ret-type)How to Test
Verify
tio-toolworks on negative argumentstio-tool rpc field.cutoff -1Also verify manual type specification of a RPC reply with
-T/--rep-type