fix bugs in concurrency chapter, "A solution: Producer/Consumer" section#124
Open
prafulliu wants to merge 2 commits intotwitter:masterfrom
Open
fix bugs in concurrency chapter, "A solution: Producer/Consumer" section#124prafulliu wants to merge 2 commits intotwitter:masterfrom
prafulliu wants to merge 2 commits intotwitter:masterfrom
Conversation
…gnostic RPC System" is expired, I changed it to the new link in twitter's Engineering Blog. Also in other languages' translation.
Author
|
fix link error in Finagle chapter, A link to "Finagle: A Protocol-Agnostic RPC System" is expired, I changed it to the new link in twitter's Engineering Blog. Also in other languages' translation. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the end of the _concurrency_ chapter, there is a demo named _A solution: Producer/Consumer_ has some bugs.
I also fixed them in Russian, Korea and Chinese.
val queue = new LinkedBlockingQueue[String]()But the other code use
qfor this instance, so it's an error.2.
The second
iis error, it should be1.3.
indexis not declared.class Producer[T](path: String, queue: BlockingQueue[T]) extends Runnable { def run() { Source.fromFile(path, "utf-8").getLines.foreach { line => queue.put(line) } } }queue.put(line)inProducerclass will call an error.Change it to
class Producer[T>:String](path: String, queue: BlockingQueue[T]) extends Runnable {or
class Producer[T](path: String, queue: BlockingQueue[String]) extends Runnable {can fix it.