Set leeway on Datetime Claims creation #2182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrodolci
force-pushed
the
set-leeway-on-claim-creation
branch
from
9b32887 to
b906044
Compare
ArthurYdalgo
added a commit
to ArthurYdalgo/jwt-auth
that referenced
this pull request
Jun 1, 2023
Copied from this PR: tymondesigns#2182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
leewayproperty of Datetime claims is set after the instance creation, calling the relative setter method. This could cause validation errors inside thevalidateCreatemethod of theIssuedAtclass, in the case where an instance gets created using a value from an existing token, due to the leeway not being considered.This has caused some problems on one of our services that was running on a pool of different hosts which happened to have their system clocks out of sync. We solved the issue by fixing our NTP configurations, but we'd appreciate the
leewayproperty to be correctly handled by the library.The problem seems to be also mentioned here.
We really appreciate your effort with this project and we hope you find this helpful. I'm always available if you need me to further expand on this.
Have a nice weekend!