Skip to content

Fix transaction on_close and Java and Python block on close() #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fix transaction on_close and Java and Python block on close() #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e907782
Improve Rust on_close_callback
flyingsilverfin Sep 26, 2025
a87a9d7
Trigger CI
flyingsilverfin Sep 30, 2025
df3ba3a
Deploy snapshot
flyingsilverfin Sep 30, 2025
b1b3f5b
Fix build
flyingsilverfin Sep 30, 2025
ebf41f5
Include mutex
flyingsilverfin Sep 30, 2025
cbf1d84
Fix drop behaviour
flyingsilverfin Oct 1, 2025
9e94c90
Trigger CI
flyingsilverfin Oct 1, 2025
a3bbf3a
Use built-in Python 3.11 in mac jobs
flyingsilverfin Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ commands:
type: string
steps:
- run: |
brew install [email protected]
# brew install [email protected]
curl -OL "https://github.com/bazelbuild/bazelisk/releases/download/v1.17.0/bazelisk-darwin-<<parameters.bazel-arch>>"
sudo mv "bazelisk-darwin-<<parameters.bazel-arch>>" /usr/local/bin/bazel
chmod a+x /usr/local/bin/bazel
Expand Down Expand Up @@ -149,7 +149,7 @@ commands:
steps:
- install-brew-rosetta
- run: |
/usr/local/bin/brew install [email protected]
# /usr/local/bin/brew install [email protected]
tool/test/start-community-server.sh
/usr/local/bin/python3.9 -m pip install wheel
/usr/local/bin/python3.9 -m pip install pip==21.3.1
Expand Down Expand Up @@ -850,32 +850,32 @@ workflows:
- deploy-snapshot-linux-arm64:
filters:
branches:
only: [development, master, "3.0"]
only: [development, master, improve-on-close-callback]

- deploy-snapshot-linux-x86_64:
filters:
branches:
only: [development, master, "3.0"]
only: [development, master, improve-on-close-callback]

- deploy-snapshot-mac-arm64:
filters:
branches:
only: [development, master, "3.0"]
only: [development, master, improve-on-close-callback]

- deploy-snapshot-mac-x86_64:
filters:
branches:
only: [development, master, "3.0"]
only: [development, master, improve-on-close-callback]

- deploy-snapshot-windows-x86_64:
filters:
branches:
only: [development, master, "3.0"]
only: [development, master, improve-on-close-callback]

- deploy-snapshot-any:
filters:
branches:
only: [development, master, "3.0"]
only: [development, master, improve-on-close-callback]
requires:
- deploy-snapshot-linux-arm64
- deploy-snapshot-linux-x86_64
Expand Down
107 changes: 74 additions & 33 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions c/src/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ pub extern "C" fn transaction_close(txn: *mut Transaction) {

/// Forcibly closes this transaction. To be used in exceptional cases.
#[no_mangle]
pub extern "C" fn transaction_force_close(txn: *mut Transaction) {
borrow_mut(txn).force_close();
pub extern "C" fn transaction_force_close(txn: *mut Transaction) -> *mut VoidPromise {
release(VoidPromise(Box::new(borrow_mut(txn).force_close())))
}

/// Commits the changes made via this transaction to the TypeDB database.
Expand Down
Loading