-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add Ollama as chat completion and embedding provider #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iceysteel
wants to merge
9
commits into
typedef-ai:main
Choose a base branch
from
iceysteel:ollama-provider-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b3ee13e
Implement native Ollama provider integration with dynamic model disco…
iceysteel d56135f
feat: export ollama provider and update examples with cli args
iceysteel c248437
feat: add ollama-specific rate limiting strategy
iceysteel ee2caa3
refactor: use ollama /api/show endpoint for model metadata
iceysteel 274e6ea
fix: simplified json prompts for local models in ollama provider
iceysteel fc39aea
feat: auto-pull missing ollama models during validation
iceysteel 7189901
fix: dynamic embedding dimensions from ollama model metadata
iceysteel 2be2887
feat: simplify Ollama provider with single model constraints and pass…
iceysteel 39137ea
refactor: replace Ollama multi-model blocking with warning
iceysteel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep OpenAI as the default provider for all examples, so let's revert the recent changes to the example scripts.
For testing different providers, we already use examples_session_config (see tests/conftest.py#L171
). This allows the example scripts to be run with Ollama—or any other provider—during unit tests, without needing to modify the examples themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do all unit tests pass using your choice of local models?