copy body over request retries in a multi-node request #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guialbuquerque5
changed the title
haydenhoang
added a commit
to haydenhoang/typesense-go
that referenced
this pull request
Mar 27, 2025
|
Thanks, this required a test fix, which has been added in another PR along with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
I encountered this issue when retrying an import request on the next node:
http: ContentLength=3939 with Body length 0.
After reviewing the code, I realized that the request body was being reused across retries. Since the body is closed after the first request, this caused the error.
The fix ensures that the body is copied and re-instantiated for each retry, preventing this issue.
PR Checklist