fix: type signature for ImportDocumentResponse #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When given return_doc=true in the query to the bulk import API, Typesense returns a valid JSON object in the `document` field of the response. On failure (for example invalid JSON), the raw string from the request is echoed in the response instead. This change makes the Go SDK compatible with that behavior.
haydenhoang
added a commit
to haydenhoang/typesense-go
that referenced
this pull request
May 19, 2025
|
@jasonbosco I have added an integration test for this PR here, could you merge it? Thanks for the fix @alnr! |
jasonbosco
added a commit
that referenced
this pull request
May 22, 2025
Add integration test for PR #202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When given
return_doc=truein the query to the bulk import API, Typesense returns a valid JSON object in thedocumentfield of the response.On failure (for example invalid JSON), the raw string from the request is echoed in the response instead.
This change makes the Go SDK compatible with that behavior.
I've also improved the implementation of
(*documents) Import(). Previously, it ignored junk output appended to valid JSON. It now rejects anything but JSONL.PR Checklist