fix: expose total hits for pagy to use#18
Closed
tharropoulos wants to merge 1 commit intotypesense:masterfrom
Closed
fix: expose total hits for pagy to use#18tharropoulos wants to merge 1 commit intotypesense:masterfrom
tharropoulos wants to merge 1 commit intotypesense:masterfrom
Conversation
jasonbosco
requested changes
Feb 20, 2026
| @typesense_json["facet_counts"] | ||
| end | ||
|
|
||
| def total_hits |
Member
There was a problem hiding this comment.
@tharropoulos Every other method in the AdditionalMethods module has the prefix typesense_, so this method stands out as odd to me... Can we name this typesense_found and then may be create an alias method with an additional name for Pagy to use?
Contributor
Author
There was a problem hiding this comment.
This will be closed, pagy doesn't rely on this method anymore, using the raw found value from the JSON response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Pagy's
typesensepaginator relies ontotal_hits, which isn't exposed without a pagination backend, but that pagination backend shouldn't be defined for #17 's usecase.PR Checklist