Update to PHP v8.5 #93
Draft
+47
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request attempts to update the project's PHP version requirement from 8.4 to 8.5. However, PHP 8.5 does not exist as of November 2025. PHP 8.4 was released in November 2024 and is currently the latest stable version. This update will cause failures across the project.
Key Changes:
- PHP version updated from
^8.4to^8.5in composer.json and composer.lock - GitHub Actions workflows updated to use PHP 8.5
- craft.yml configuration updated to PHP 8.5
- Various dependency version bumps in composer.lock (nunomaduro/collision, nunomaduro/termwind, pestphp/pest, phpdocumentor packages, theseer/tokenizer)
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| craft.yml | Updates PHP version configuration to non-existent PHP 8.5 |
| composer.json | Changes PHP requirement constraint to ^8.5 which is invalid |
| composer.lock | Reflects the invalid PHP 8.5 platform requirement and includes dependency version updates |
| .github/workflows/update-version-data.yml | Updates workflow to use non-existent PHP 8.5 |
| .github/workflows/test.yml | Updates test workflows (two jobs) to use non-existent PHP 8.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.