Skip to content

Conversation

@Drodt
Copy link
Contributor

@Drodt Drodt commented Oct 8, 2024

Fixes #219.

Also fixes the error that affixes for bibliography layout were ignored. And updates archives.

Adds 4 tests to citeproc-pass.txt.

Still a draft until:

  • Code is reworked to be a bit nicer
  • Tests for bibliography are supported (See Support for Citeproc bibliography tests #229).
  • All relevant tests pass:
    • name_SubsequentAuthorSubstituteSingleField
    • name_SubstitutePartialEach
    • name_SubsequentAuthorSubstituteMultipleNames

@Drodt Drodt marked this pull request as ready for review October 17, 2024 07:20
@Drodt
Copy link
Contributor Author

Drodt commented Nov 25, 2024

This is ready to merge.

Copy link
Contributor

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, here are some initial thoughts.

@PgBiel PgBiel mentioned this pull request Feb 3, 2025
2 tasks
@reknih
Copy link
Member

reknih commented Feb 5, 2025

I have merged main in here, removed the HTML testing in favor of #273, and got rid of the archive updates.

Two tests are failing now:

  • bugreports_parenthesis, first passed in your PR before my merge
  • substitute_SuppressOrdinaryVariable, first passed in 1058be7 on main

@reknih
Copy link
Member

reknih commented Feb 5, 2025

Also moved f219.rs to a local test

@Drodt
Copy link
Contributor Author

Drodt commented Apr 17, 2025

I have merged main in here, removed the HTML testing in favor of #273, and got rid of the archive updates.

Thanks

Two tests are failing now:

* `bugreports_parenthesis`, first passed in your PR before my merge

The issue here is that citeproc removes collapses two spaces following each other, while hayagriva does not. Does hayagriva do any of the other such simplifcations that citeproc does, e.g., transforming !. to !?

* `substitute_SuppressOrdinaryVariable`, first passed in [1058be7](https://github.com/typst/hayagriva/commit/1058be7dab3d34bb317e26360d79b2830cb391ed) on main

Fixed

@Drodt
Copy link
Contributor Author

Drodt commented Apr 17, 2025

I removed bugreports_parseName in favor of opening #304

@Drodt
Copy link
Contributor Author

Drodt commented Apr 28, 2025

This PR is also ready, once you have the time.

@PgBiel
Copy link
Contributor

PgBiel commented Aug 12, 2025

Big sorry for the delay by the way, I've been incrementally reviewing this PR for several weeks now, but there's quite a bit going on and I wanted to think it through 😅
I'll try to conclude the first round soon.

@Drodt
Copy link
Contributor Author

Drodt commented Sep 10, 2025

I just fixed the imports and the resulting formatting issues. Nothing that would impact your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subsequent-author-substitute is not respected

4 participants