-
-
Notifications
You must be signed in to change notification settings - Fork 68
Add Collation-Based String Sorting #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It's a non-starter for us. It won't be installed on the Typst web app for example. icu4x1 is an alternative. However, there are concerns about the size of the collation data it pulls, and how this could impact the size of e.g. the Typst binary, Typst on the web app etc. One alternative that was considered is to delegate this job to a trait which implements localized sorting and let upstream users (i.e. Typst) handle it. We're not fully decided on this, but it's at least better than the status quo. Footnotes |
|
For now I switched to icu4x. Let me know if the typst team wants another solution |
Previously, Hayagriva did not compare UTF-8 strings correctly #193. This is due to how Rust compares UTF-8 Strings. This PR addresses the issue by using
icu_ucolfor comparison, using the current locale.Fixes #193 and adds one test to citeproc-pass.
Adds
rust_icu_ucolas a dependency. Problem: icu must be installed on the user's system. How do we handle this?I might have missed some comparison in
csl_cmp.