Add parsing of Xiaomi devices #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoldstein0
requested changes
Sep 17, 2025
There was a problem hiding this comment.
This is the wrong repo to make the change to. uaparser/yaml.go is generated by https://github.com/ua-parser/uap-go/blob/master/build.sh from our submodule of ua-parser/uap-core. All regex changes ought to be first reviewed and merged into that repository. If you go that route, I'd be happy to accept a submodule update of uap-core to pull in any changes you contribute there.
|
My bad, didn't catch that. Just created a new PR towards the proper repository ua-parser/uap-core#639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it that the device parsing for Xiaomi devices stop returning:
but instead: