Derive Clone for Value and ValueRef #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having `Clone` on `Value` makes it very difficult to store extracted values in a cache, and there seems to be no reason I can see to not implement `Clone` on `ValueRef` as well, since there are legitimate use-cases for it and it is impossible for downstream consumers to implement Clone themselves.
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having
CloneonValuemakes it very difficult to store extracted values in a cache, and there seems to be no reason I can see to not implementCloneonValueRefas well, since there are legitimate use-cases for it and it is impossible for downstream consumers to implement Clone themselves.