Open
Conversation
added 14 commits
October 19, 2015 15:41
…late file (need to be tested).
…s + FullAdder{Decoupled}.
…on-Decoupled signals -> all works fine.
…ype (only for test).
Contributor
|
This is great. I've squashed your commits and merged them into a new Chisel branch: systemcupdatepr560 One of our tests failed (SystemCSuite.testTopLevelIO) since we no longer get failures for top-level IOs that aren't decoupled. I've changed the expected test results so this no longer expects failures and now passes. Can you verify that this is the expected behaviour? Please add some tests of this new functionality. Push any new changes to this branch ( https://github.com/ucb-bar/chisel/tree/systemcupdatepr560). |
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been working recently on Chisel SystemC backend to support all signals and ports like Decoupled and Valid, also we improved the automatic generation of the SystemC wrappers.
Now, we are submitting this request to be evaluated and integrated into Chisel, if approved.