Replace relative paths with absolute ones#27
Open
OoJJBoO wants to merge 1 commit intoukoethe:masterfrom
Open
Conversation
… when launching the game from an external directory. Replace string concatenation with f-strings for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the game uses relative paths to locate agent images and store logging data.
This results in two issues when launching the game from outside its root directory:
agent_codedirectory is created in the working directory for logging.While these are, of course, only minor inconveniences, I would suggest to replace the use of relative paths with absolute ones instead, which would prevent the aforementioned behavior.