-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Section Sidebar Menu Expansion #19810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces an 'events' property to UmbExtensionSlotElement, allowing dynamic assignment and removal of event listeners on extension components. Event listeners are added when extensions are permitted and removed on disconnect, improving extensibility and event handling for extension slots.
Introduces handlers for entity expansion and collapse events in the section sidebar menu. This change enables the menu to respond to expansion state changes by updating the context accordingly.
Introduces a local expansion state to both section sidebar and tree menu item components to prevent unnecessary updates and rerenders. This improves performance by ensuring state updates only occur when needed.
nielslyngsoe
approved these changes
Aug 28, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to remember the Section Sidebar Menu state across sections. It also introduces different contexts to interact with the menu from the backoffice. The state remains synchronized across all contexts. No matter where the state is updated, it will be reflected in the related contexts.
The PR includes a sample playground that demonstrates the current state for the section and across sections via dashboards. It is possible to close any open menu item from the dashboard. The example also registers a "Collapse Menu Item"-entity action to show interaction with a local menu item state.
Demo video of the example:
https://github.com/user-attachments/assets/d1267a87-f76e-42aa-a8d5-aa76e6a53741
Global State
UMB_SECTION_SIDEBAR_MENU_GLOBAL_CONTEXTWraps the entire application and tracks states for all sections.
Section State
UMB_SECTION_SIDEBAR_MENU_SECTION_CONTEXTWraps a section and tracks the state for all menu items inside a section
Menu Item State
UMB_MENU_ITEM_CONTEXTWraps the menu item and tracks the state for this menu item.
Partly fix of #17074
Partly fix of #17076
Additional PRs coming to support deep link into paginated tree structure menus and remembering the last visited item when navigating between sections.