-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Slider: improved value fallback handling + validation #20228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nielslyngsoe
wants to merge
11
commits into
main
Choose a base branch
from
v16/feature/improve-slider-value-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+172
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the slider property editor's value handling to properly accept 0 values without fallback issues and adds comprehensive validation.
- Enhanced value fallback logic to treat 0 as a valid value instead of triggering fallback behavior
- Added proper validation for range overflow, underflow, and configuration errors
- Refactored type definitions to use interfaces for better type safety
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
types.ts | Adds interface definition for slider value object |
property-editor-ui-slider.element.ts | Implements form validation mixin and improves value handling logic |
input-slider.element.ts | Adds validation rules and refactors value property handling |
input-number-range.element.ts | Updates error message to use localization key |
localization.controller.ts | Adds documentation examples for the term method |
en.ts | Adds new localization key for range validation error |
src/Umbraco.Web.UI.Client/src/packages/core/components/input-slider/input-slider.element.ts
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
September 23, 2025 09:21
Pull request was converted to draft
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved slider value handling to accept a value to be 0 without doing a fallback. Plus validation implementation.