Skip to content

Conversation

nielslyngsoe
Copy link
Member

Improved slider value handling to accept a value to be 0 without doing a fallback. Plus validation implementation.

@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 08:34
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) September 23, 2025 08:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the slider property editor's value handling to properly accept 0 values without fallback issues and adds comprehensive validation.

  • Enhanced value fallback logic to treat 0 as a valid value instead of triggering fallback behavior
  • Added proper validation for range overflow, underflow, and configuration errors
  • Refactored type definitions to use interfaces for better type safety

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
types.ts Adds interface definition for slider value object
property-editor-ui-slider.element.ts Implements form validation mixin and improves value handling logic
input-slider.element.ts Adds validation rules and refactors value property handling
input-number-range.element.ts Updates error message to use localization key
localization.controller.ts Adds documentation examples for the term method
en.ts Adds new localization key for range validation error

@umbraco umbraco deleted a comment from Copilot AI Sep 23, 2025
@umbraco umbraco deleted a comment from Copilot AI Sep 23, 2025
@nielslyngsoe nielslyngsoe marked this pull request as draft September 23, 2025 09:21
auto-merge was automatically disabled September 23, 2025 09:21

Pull request was converted to draft

@nielslyngsoe nielslyngsoe marked this pull request as ready for review September 23, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant